-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubeflow, kubeflow-katib and kubeflow-pipelines: total 20 images and restructure kubeflow-volumes-web-app #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
806aee3
to
08bc7f5
Compare
Advisory data is ready: wolfi-dev/advisories#233 |
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev> Co-authored-by: Batuhan <batuhan.apaydin@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev> Co-authored-by: Batuhan <batuhan.apaydin@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev> Co-authored-by: Batuhan <batuhan.apaydin@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev> Co-authored-by: Batuhan <batuhan.apaydin@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev> Co-authored-by: Batuhan <batuhan.apaydin@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev> Co-authored-by: Batuhan <batuhan.apaydin@chainguard.dev>
2a3180d
to
7b88cc9
Compare
7b88cc9
to
d177999
Compare
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev>
3f052ad
to
97afdb0
Compare
97afdb0
to
4e4799e
Compare
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev>
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev> Co-authored-by: Batuhan <batuhan.apaydin@chainguard.dev>
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
71319c9
to
bfdb552
Compare
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
bfdb552
to
39dc98b
Compare
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev>
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev> Co-authored-by: Batuhan <batuhan.apaydin@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Nvm I see this just got moved around. |
jonjohnsonjr
previously requested changes
Sep 13, 2023
joshrwolf
reviewed
Sep 14, 2023
joshrwolf
reviewed
Sep 14, 2023
joshrwolf
reviewed
Sep 14, 2023
images/kubeflow-pipelines/configs/latest.cache-deployer.apko.yaml
Outdated
Show resolved
Hide resolved
joshrwolf
reviewed
Sep 14, 2023
joshrwolf
reviewed
Sep 14, 2023
images/kubeflow-pipelines/configs/latest.metadata-writer.apko.yaml
Outdated
Show resolved
Hide resolved
joshrwolf
reviewed
Sep 14, 2023
joshrwolf
reviewed
Sep 14, 2023
joshrwolf
reviewed
Sep 14, 2023
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
approving to unblock this batch, but the following need to be addressed in a follow up:
|
joshrwolf
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark
kubeflow
volumes-web-app
Follow-up CVE fix: wolfi-dev/os#4816
https://github.com/kubeflow/kubeflow/blob/master/components/crud-web-apps/volumes/Dockerfile
jupyter-web-app
https://github.com/kubeflow/kubeflow/blob/master/components/crud-web-apps/jupyter/Dockerfile
kubeflow-katib
controller
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/katib-controller/v1beta1/Dockerfile
db-manager
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/db-manager/v1beta1/Dockerfile
file-metricscollector
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/metricscollector/v1beta1/file-metricscollector/Dockerfile
suggestion-goptuna
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/suggestion/goptuna/v1beta1/Dockerfile
suggestion-optuna
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/suggestion/optuna/v1beta1/Dockerfile
suggestion-hyperband
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/suggestion/hyperband/v1beta1/Dockerfile
suggestion-hyperopt
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/suggestion/hyperopt/v1beta1/Dockerfile
suggestion-skopt
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/suggestion/skopt/v1beta1/Dockerfile
suggestion-pbt
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/suggestion/pbt/v1beta1/Dockerfile
suggestion-darts
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/suggestion/nas/darts/v1beta1/Dockerfile
earlystopping-medianstop
Dockerfile: https://github.com/kubeflow/katib/blob/master/cmd/earlystopping/medianstop/v1beta1/Dockerfile
kubeflow-pipelines
cache-server
Dockerfile: https://github.com/kubeflow/pipelines/blob/master/backend/Dockerfile.cacheserver
cache-deployer
Dockerfile: https://github.com/kubeflow/pipelines/blob/master/backend/src/cache/deployer/Dockerfile
api-server
Dockerfile:
https://github.com/kubeflow/pipelines/blob/master/backend/Dockerfile
metadata-writer
Dockerfile:
https://github.com/kubeflow/pipelines/blob/master/backend/metadata_writer/Dockerfile
persistenceagent
Dockerfile:
https://github.com/kubeflow/pipelines/blob/master/backend/Dockerfile.persistenceagent
scheduledworkflow
Dockerfile:
https://github.com/kubeflow/pipelines/blob/master/backend/Dockerfile.scheduledworkflow
viewer-crd-controller
Dockerfile:
https://github.com/kubeflow/pipelines/blob/master/backend/Dockerfile.viewercontroller
Chainguard Images Pull Request Template
Image Size
Notes:
Image Vulnerabilities
Notes:
Basic Testing - K8s cluster
Notes:
Basic Testing - Package/Application
Notes:
Helm
Notes: Used kustomize to test
Processor Architectures
Notes:
Functional Testing + Documentation
Notes:
Environment Testing + Documentation
Notes:
Version
Notes:
Dev Tag Availability
Notes:
Access Control + Authentication
nonroot
and GID/UID are set to 65532 or upstream defaultENTRYPOINT
CMD
–help
Environment Variables
SIGTERM
docker kill $(docker run -d --rm cgr.dev/chainguard/nginx)
)Logs
Documentation - README