add support for appending indexes with oci_append #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
approved these changes
Jul 29, 2024
Merged
joshrwolf
added a commit
that referenced
this pull request
Aug 5, 2024
the index append introduced in #155 created a valid index but didn't properly append the image contents to it. instead it was simply appending an index manifest to the index 🤦 this PR fixes that and adds another test to catch it (I think?). ideally I'd like the test to push up a platform specific image(s) but I can't figure out how to do that with `random.Image`. I've at least tested this locally and it appears to be generating a proper index: ``` { "schemaVersion": 2, "mediaType": "application/vnd.oci.image.index.v1+json", "manifests": [ { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 562, "digest": "sha256:c5316b34c4564257960ce18e73b6f421cae0e67c5e3cf18a97cd755947c071c4", "platform": { "architecture": "amd64", "os": "linux" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 561, "digest": "sha256:dad0b65b0a055bcee31b5888d5435c5f73e25785f0e92be473996fb060bb62eb", "platform": { "architecture": "arm64", "os": "linux" } } ] } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splits the existing image only
oci_appendinto 2 legs, one using the existingimageonly approach and the other with a loop appending the indexes