Add support for multiple attestations at once #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should bikeshed exact format and names here.
Combined with: chainguard-dev/terraform-publisher-apko#18
I instrumented
terraform
output how long eachWriteState
invocation took, then ran a few things locally before and after.With just a single module, things look not that different...
Total
WriteState
latency: 5.7s -> 4.185s (~27% drop)Number of
WriteState
calls: 344 -> 260 (~24% drop)But if we pull in some more modules:
Total
WriteState
latency: 50s -> 33s (~34% drop)Number of
WriteState
calls: 1078 -> 796 (~26% drop)If we look plot each point (milliseconds), we see something like this:
The latency for each
WriteState
grows ~linearly with the the size of theterraform.tfstate
file, which is proportional to the number of resources, so the overall latency will grow quadratically.Terraform also allocates two new buffer that end up growing to be the size of the
terraform.tfstate
file (and the previous file), so this also starts to cause a lot of GC pressure as the size increases.