Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cosign_copy #28

Merged
merged 8 commits into from
Jun 3, 2023
Merged

add cosign_copy #28

merged 8 commits into from
Jun 3, 2023

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jun 3, 2023

I haven't tested this locally since it requires ambient creds to sign, but I've at least tested that the cosign_verify fails with the expected warning about missing ambient creds.

@imjasonh
add cosign_copy
e4fb301 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh requested a review from mattmoor June 3, 2023 16:58
imjasonh added 2 commits June 3, 2023 13:33
@imjasonh
add cosign_copy
935b24d 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
the verified ref should be in the destination repo
3183e7a 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh enabled auto-merge (squash) June 3, 2023 17:41
imjasonh added 3 commits June 3, 2023 14:09
@imjasonh
test copying attestations
7750a09 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
copy to digest more clearly
c4d5e3f 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
go generate
20a39d4 
Signed-off-by: Jason Hall <jason@chainguard.dev>
mattmoor
mattmoor reviewed Jun 3, 2023
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You created a race in the test

internal/provider/resource_copy_test.go Outdated Show resolved Hide resolved
internal/provider/resource_copy_test.go Outdated Show resolved Hide resolved
mattmoor
mattmoor reviewed Jun 3, 2023
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You created a race in the test

@imjasonh
fix race
b3f8107 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
fix attested_ref
880b42b 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh merged commit f4f60a9 into chainguard-dev:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjasonh @mattmoor