add helper function to get changed files #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiz Scan Summary
|
joshrwolf
force-pushed
the
sdk/changed-files
branch
2 times, most recently
from
298e020 to
ddeabca
Compare
joshrwolf
force-pushed
the
sdk/changed-files
branch
from
ddeabca to
8fe4027
Compare
joshrwolf
force-pushed
the
sdk/changed-files
branch
from
8fe4027 to
91e391a
Compare
k4leung4
reviewed
Sep 24, 2024
| } | ||
|
|
||
| if fromCommit == nil || toCommit == nil { | ||
| return nil, fmt.Errorf("one or both commits are nil") |
There was a problem hiding this comment.
nit: include the fromCommit and toCommit in the error message so its clear which one is nil or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a helper function that uses the *git.Repository struct for getting a set of changed files between the tips of two branches.
this intentionally doesn't use the GH client to preserve our precious api quota