support passing alert IDs to service dashboards #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jason@chainguard.dev>
imjasonh
force-pushed
the
service-alerts
branch
from
a613384 to
d41f8a4
Compare
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
mattmoor
reviewed
Dec 22, 2023
| @@ -16,15 +16,24 @@ module "resources" { | |||
| filter = ["resource.type=\"cloud_run_revision\""] | |||
| } | |||
|
|
|||
| module "alerts" { | |||
| source = "../sections/alerts" | |||
There was a problem hiding this comment.
Suggested change
| source = "../sections/alerts" | |
| count = var.alert != "" ? 1 : 0 | |
| source = "../sections/alerts" |
There was a problem hiding this comment.
We could also consider making this a list 🤔
mattmoor
reviewed
Dec 22, 2023
| ] | ||
| source = "../sections/layout" | ||
| sections = concat( | ||
| var.alert == "" ? [] : [module.alerts.section], |
There was a problem hiding this comment.
Suggested change
| var.alert == "" ? [] : [module.alerts.section], | |
| var.alert == "" ? [] : [module.alerts[0].section], |
or
Suggested change
| var.alert == "" ? [] : [module.alerts.section], | |
| [for x in module.alerts : x.section], |
mattmoor
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should produce full-width alert chart widgets for each alert. I might need to iterate on this with changes in tf-prober to see this all working together. It at least doesn't regress for non-alert-having services.