Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test pipelines #864

Merged
merged 11 commits into from
Dec 4, 2023
Merged

Add Test pipelines #864

merged 11 commits into from
Dec 4, 2023

Conversation

vaikas
Copy link
Member

@vaikas vaikas commented Nov 27, 2023

Example test file that I've been playing with

https://gist.github.com/vaikas/b2cf4d96b7601bdccf39a2b34bcc0dc2

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

@vaikas vaikas changed the title Test pipeline WIP: Test pipeline Nov 27, 2023
@vaikas
Copy link
Member Author

vaikas commented Nov 28, 2023

ncurses test failure is unrelated, wolfi-dev/os#9128

@vaikas vaikas force-pushed the test-pipeline branch 3 times, most recently from d34a856 to ec4410c Compare November 28, 2023 13:01
@vaikas
Copy link
Member Author

vaikas commented Nov 28, 2023

I rejiggered the commits to more bite size chunks for easier review.

@vaikas vaikas force-pushed the test-pipeline branch 9 times, most recently from 5c4dbdb to ad516f1 Compare December 1, 2023 11:15
@vaikas vaikas marked this pull request as ready for review December 1, 2023 11:18
@vaikas vaikas changed the title WIP: Test pipeline Add Test pipelines Dec 1, 2023
vaikas added 10 commits December 2, 2023 14:14
@vaikas
Add autogenerated 'test' docs.
4c4ff86 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
config struct changes for test.
044103b 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Refactor so can be used with test and build.
73d1943 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
alphabetize commands, add test.
c987b0f 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Add test command / implementation.
01997da 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
checkpoint.
4fbc1d4 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
e2e tests for test command.
c219511 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Add tests, simplify code.
9a017cc 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
argh, fix typo.
6f39b98 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Default to package.name, but allow overrides, add example docs for sp…
84d4b66 
…ecifying which package, and version to test.

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
fix bad merge.
cd69237 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@kaniini
Copy link
Contributor

kaniini commented Dec 4, 2023

This looks good to me!

@vaikas vaikas merged commit 79f8b9b into chainguard-dev:main Dec 4, 2023
29 checks passed
@vaikas vaikas deleted the test-pipeline branch December 4, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspeed-meyers jspeed-meyers jspeed-meyers left review comments

@kaniini kaniini kaniini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaikas @kaniini @jspeed-meyers