feat: add new Perl pipelines for Makefile generation and cleanup #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add two new Perl pipelines for repetitive tasks: install and cleanup. Signed-off-by: Mauren Berti <mauren.berti@chainguard.dev>
luhring
reviewed
Sep 5, 2023
|
|
||
| pipeline: | ||
| - runs: | | ||
| export CFLAGS=$(perl -MConfig -E 'say $Config{ccflags}') |
There was a problem hiding this comment.
Dumb question: is there a chance this will clobber existing environment values for CFLAGS? And would that be intentional?
There was a problem hiding this comment.
That's a good question I don't really have a good answer to 😬
I meant to externalize what's currently being used in these build files (and others I've created in the context of wolfi-dev/os#5051):
There was a problem hiding this comment.
I think we should capture that output into $PERL_CFLAGS and then append it to $CFLAGS.
There was a problem hiding this comment.
I'll update it!
There was a problem hiding this comment.
Changed it to append. Is space OK between contents?
2 tasks
vaikas
reviewed
Sep 5, 2023
Signed-off-by: Mauren Berti <mauren.berti@chainguard.dev>
stormqueen1990
changed the title
vaikas
approved these changes
Sep 6, 2023
kaniini
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new Perl pipelines for repetitive tasks: Makefile generation based on a Perl module and cleanup after installation.