Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/python version issue #532

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Fix/python version issue #532

merged 2 commits into from
Jul 8, 2023

Conversation

mesaglio
Copy link
Contributor

@mesaglio mesaglio commented Jul 4, 2023

This pr solve #531 issue.

I change the SetupContext function to return an array of *PythonContext to force a test with ! in version.

mesaglio added 2 commits July 2, 2023 23:14
@mesaglio
Add ! char to ignore.
b3189ed 
Signed-off-by: Juan Mesaglio <juan.mesaglio@gmail.com>
@mesaglio
Merge branch 'main' into fix/python_version_issue
f4214a0 
Signed-off-by: Juan Mesaglio <juan.mesaglio@gmail.com>
@mesaglio mesaglio requested a review from a team as a code owner July 4, 2023 00:53
@mesaglio mesaglio requested review from dlorenc and removed request for a team July 4, 2023 00:53
@mesaglio
Copy link
Contributor Author

mesaglio commented Jul 8, 2023

@imjasonh @kaniini

@kaniini kaniini enabled auto-merge July 8, 2023 22:36
@kaniini kaniini merged commit 2bf0a3f into chainguard-dev:main Jul 8, 2023
@mesaglio mesaglio mentioned this pull request Jul 10, 2023
Closed
@deitch
Copy link
Contributor

deitch commented Jul 11, 2023

@mesaglio I see melange tests failing on python_test.go, see for example this run https://github.com/chainguard-dev/melange/actions/runs/5517264026/jobs/10059642524?pr=542 . Is it related to this PR?

@mesaglio
Copy link
Contributor Author

@deitch I think this test broken because in python convert test, this going to pypi to get the latest version and in the last version on jsonschema was added some deps like jsonschema-specifications>=2023.03.6 and we dont have this json file mocked.
I'm working on fix this.

@deitch
Copy link
Contributor

deitch commented Jul 11, 2023

Thanks @mesaglio ; kindly comment here when you have a fix.

@rawlingsj
Copy link
Member

Wonder if we should revert the original PR and work on the fix adding the changes back in? Currently CI is broken so it's blocking PRs merging and releasing.

Unless the fix is pretty straightforward and can be added soon?

@deitch deitch mentioned this pull request Jul 11, 2023
Merged
@mesaglio
Copy link
Contributor Author

Hi @rawlingsj, yes you revert if you like. I'm woking on this right now.

@mesaglio mesaglio deleted the fix/python_version_issue branch July 13, 2023 01:44
@Porkepix Porkepix mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaniini kaniini kaniini approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc dlorenc was automatically assigned from chainguard-dev/images-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mesaglio @deitch @rawlingsj @kaniini