Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otel spans #529

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Add otel spans #529

merged 1 commit into from
Jul 5, 2023

Conversation

jonjohnsonjr
Copy link
Contributor

Given this and these:

We can do nice things like see where melange build latency is being spent across both melange and apko.

We spend a good amount of time in BuildGuest (working on that: chainguard-dev/apko#781):
image

Loading the image into docker takes longer than I'd expect:

image

But this will be particularly useful when we hit some pathological case where we have unexpected latency.

@jonjohnsonjr jonjohnsonjr requested a review from a team as a code owner July 3, 2023 14:51
@jonjohnsonjr jonjohnsonjr requested review from dlorenc and removed request for a team July 3, 2023 14:51
Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
@jonjohnsonjr
Copy link
Contributor Author

Once we merge the go-apk and apko PRs, I'll need to bump melange's dep on them and fix some missing context parameters to make sure we have a full chain of context propagation.

@imjasonh imjasonh merged commit 69df956 into chainguard-dev:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants