Add build user to test pipeline environments #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebeattie
changed the title
stevebeattie
force-pushed
the
add-build-user-to-test-environments
branch
from
bf6c329 to
f4e3638
Compare
The Test pipeline environment does not get a build user included by default; this causes test pipelines to fail when the qemu runner is used because the initial connection attempt to get the host public key always uses the build user to connect. Fix this by adding the build user to all Test environments, both the primary pipeline and any subpipelines. Fixes: chainguard-dev#1732 Signed-off-by: Steve Beattie <steve.beattie@chainguard.dev>
Signed-off-by: Evan Gibler <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
stevebeattie
force-pushed
the
add-build-user-to-test-environments
branch
from
f4e3638 to
673caab
Compare
89luca89
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional Changes
This change adds the build user as a default to the Test pipeline environments; without this change the qemu runner does not successfully make its ssh initial connection to the qemu microvm to get the VM's host ssh public key; see #1732 which this PR is intended to resolve.
It changes the emitted apko config for test pipelines to include:
Fixes #1732
Notes:
I have not rebuilt the world with this, but attempts to rebuild and run the test pipelines random packages (systemd, openjdk, and some others) in a variety of runners with this change have not shown breakage.