Set user GID after user and group are created

Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
chainguard-dev · Feb 7, 2025 · 1d50cef · 1d50cef
1 parent cf2e844
commit 1d50cef
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -1360,12 +1360,19 @@ func ParseConfiguration(_ context.Context, configurationFilePath string, opts ..
 	cfg.Data = nil // TODO: zero this out or not?
 
 	// TODO: validate that subpackage ranges have been consumed and applied
+	usr := apko_types.User{
+		UserName: "build",
+		UID:      1000,
+	}
 
 	grp := apko_types.Group{
 		GroupName: "build",
 		GID:       1000,
-		Members:   []string{"build"},
+		Members:   []string{usr.UserName},
 	}
+
+	usr.GID = apko_types.GID(&grp.GID)
+
 	cfg.Environment.Accounts.Groups = append(cfg.Environment.Accounts.Groups, grp)
 	if cfg.Test != nil {
 		cfg.Test.Environment.Accounts.Groups = append(cfg.Test.Environment.Accounts.Groups, grp)
@@ -1377,12 +1384,6 @@ func ParseConfiguration(_ context.Context, configurationFilePath string, opts ..
 		sub.Test.Environment.Accounts.Groups = append(sub.Test.Environment.Accounts.Groups, grp)
 	}
 
-	gid1000 := uint32(1000)
-	usr := apko_types.User{
-		UserName: "build",
-		UID:      1000,
-		GID:      apko_types.GID(&gid1000),
-	}
 	cfg.Environment.Accounts.Users = append(cfg.Environment.Accounts.Users, usr)
 	if cfg.Test != nil {
 		cfg.Test.Environment.Accounts.Users = append(cfg.Test.Environment.Accounts.Users, usr)