Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from go-yara to yara-x; improve performance and readability #734

Merged
merged 30 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
dcac602
Swap over to yara-x; improve performance and readability
egibs Dec 21, 2024
7810b35
Merge branch 'main' into use-yara-x-take-2
egibs Dec 24, 2024
e792cc2
Refresh test data
egibs Dec 24, 2024
cbeb769
Small concurrency tweaks
egibs Dec 27, 2024
0611ab5
Tweak third-party.yaml
egibs Dec 27, 2024
0b3cee5
Re-use c.Concurrency
egibs Dec 27, 2024
c731b9d
Merge branch 'main' into use-yara-x-take-2
egibs Dec 30, 2024
015dcf5
Merge branch 'main' into use-yara-x-take-2
egibs Dec 31, 2024
5998611
Refresh test data
egibs Dec 31, 2024
fc6d6d1
Fix stats JSON test
egibs Dec 31, 2024
05da5c8
Add UPX to Workflows
egibs Dec 31, 2024
f1fedf3
Replace empty match strings with the matched patterns
egibs Dec 31, 2024
62c07b6
Revert str variable change
egibs Dec 31, 2024
297bd1e
Use code highlighting to avoid escaping patterns
egibs Dec 31, 2024
3832c87
Merge branch 'main' into use-yara-x-take-2
egibs Jan 3, 2025
a82d52e
Small comment tweaks
egibs Jan 3, 2025
d3d639a
Move scanner pool assignment in refresh functions
egibs Jan 3, 2025
63746ef
One last go get -u ./...
egibs Jan 3, 2025
9c11726
Split up test jobs
egibs Jan 3, 2025
8a067ca
Merge branch 'main' into use-yara-x-take-2
egibs Jan 11, 2025
280b87b
Merge branch 'main' into use-yara-x-take-2
egibs Jan 11, 2025
f7949ed
Another round of go get -u
egibs Jan 12, 2025
980e2b2
Container hardening
egibs Jan 13, 2025
6b20338
Remove --security-opt
egibs Jan 13, 2025
f627dd7
Only run container workloads in the parent repository
egibs Jan 13, 2025
5b4980c
Update golangci-lint job
egibs Jan 13, 2025
83dfa49
Use 4-core CPU shares
egibs Jan 13, 2025
0270283
Clean up API installation instructions
egibs Jan 13, 2025
734e965
Less redundant wording
egibs Jan 13, 2025
8c78280
Simplify further
egibs Jan 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions .github/workflows/go-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,21 @@ permissions:
jobs:
test:
runs-on: mal-ubuntu-latest-8-core
container: cgr.dev/chainguard/wolfi-base:latest
container:
image: cgr.dev/chainguard/wolfi-base@sha256:eeb70e74e2ac07d3c80a30150bf473970c8b51a57f06daef3e4d065ac52489bc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to wait until CI was running consistently before locking everything down.

options: >-
--cap-add DAC_OVERRIDE
--cap-add SETGID
--cap-add SETUID
--cap-drop ALL
--cgroupns private
--cpu-shares=8192
--memory-swappiness=0
--security-opt no-new-privileges
--security-opt seccomp=default
--ulimit core=0
--ulimit nofile=1024:1024
--ulimit nproc=4096:4096
steps:
- name: Install dependencies
run: |
Expand All @@ -36,7 +50,21 @@ jobs:

integration:
runs-on: mal-ubuntu-latest-8-core
container: cgr.dev/chainguard/wolfi-base:latest
container:
image: cgr.dev/chainguard/wolfi-base@sha256:eeb70e74e2ac07d3c80a30150bf473970c8b51a57f06daef3e4d065ac52489bc
options: >-
--cap-add DAC_OVERRIDE
--cap-add SETGID
--cap-add SETUID
--cap-drop ALL
--cgroupns private
--cpu-shares=8192
--memory-swappiness=0
--security-opt no-new-privileges
--security-opt seccomp=default
--ulimit core=0
--ulimit nofile=1024:1024
--ulimit nproc=4096:4096
steps:
- name: Install dependencies
run: |
Expand Down
16 changes: 15 additions & 1 deletion .github/workflows/third-party.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,21 @@ jobs:
update:
if: ${{ github.repository }} == 'chainguard-dev/malcontent'
runs-on: mal-ubuntu-latest-8-core
container: cgr.dev/chainguard/wolfi-base:latest
container:
image: cgr.dev/chainguard/wolfi-base@sha256:eeb70e74e2ac07d3c80a30150bf473970c8b51a57f06daef3e4d065ac52489bc
options: >-
--cap-add DAC_OVERRIDE
--cap-add SETGID
--cap-add SETUID
--cap-drop ALL
--cgroupns private
--cpu-shares=8192
--memory-swappiness=0
--security-opt no-new-privileges
--security-opt seccomp=default
--ulimit core=0
--ulimit nofile=1024:1024
--ulimit nproc=4096:4096
permissions:
contents: write
id-token: write
Expand Down
Loading