This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Start gunzipping ahead of time #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we serialize installPackage, we just kind of spin doing nothing once we've expanded all the APKs. For large APKs, we are currently bottlenecked by gzip. We could cache the uncompressed tarballs, but that would eat up a bunch of disk space (which is currently a pain point). Instead, this starts decompressing as soon as we've finished expanding APKs so that we can overlap that work with installing prerequisite packages. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
imjasonh
approved these changes
Jul 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we serialize installPackage, we just kind of spin doing nothing once we've expanded all the APKs. For large APKs, we are currently bottlenecked by gzip. We could cache the uncompressed tarballs, but that would eat up a bunch of disk space (which is currently a pain point).
Instead, this starts decompressing as soon as we've finished expanding APKs so that we can overlap that work with installing prerequisite packages.
This shaves about 500ms off warm cache and 1.5s off cold cache.