This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Start installing packages as they become ready #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would wait for everything to be fetched and expanded, but this change allows us to start installing concurrently with fetches. This assumes that we must install in the exact order returend by ResolveWorld, but we can likely improve upon this. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
|
Before, you see we have to wait for everything to finish expanding before installing any packages:
After, we have overlapping fetch, expand, and install:
|
imjasonh
approved these changes
Jul 5, 2023
This was referenced Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second half of chainguard-dev/apko#775
Previously, we would wait for everything to be fetched and expanded, but this change allows us to start installing concurrently with fetches.
This assumes that we must install in the exact order returned by ResolveWorld, but we can likely improve upon this.