Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking production/development language to distroless/dev #2025

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SharpRake
Copy link
Collaborator

@SharpRake SharpRake commented Jan 18, 2025

[ ] Check if this is a typo or other quick fix and ignore the rest :)

Type of change

The main focus of this PR is to update the "Differences Between Development and Production Images" so it no longer uses this distinction.

Instead, I landed on "Distroless vs -dev images". I think this may be an imperfect solution but we haven't gotten a clear answer on the preferred language and I think this is generic enough that it won't raise too many eyebrows. I also updated a number of other docs that mention production/development images in this context. I think I captured every case where this happens.

What should this PR do?

resolves https://github.com/chainguard-dev/internal/issues/4564

Why are we making this change?

Reducing confusion, as we already use the term "Production Image" to refer to our paid tier throughout Academy.

What are the acceptance criteria?

Changes should make sense.

How should this PR be tested?

Close review of the changes, please! I did my best to reword things as necessary but some language could be clunky.

Note that if we're squeamish about this naming convention, it wasn't that big of a lift to update these docs and we could easily update them again down the line if needed.

Preview link: https://deploy-preview-2025--ornate-narwhal-088216.netlify.app/chainguard/chainguard-images/about/differences-distroless-dev/

Signed-off-by: Mark Drake <mark@chainguard.dev>
@SharpRake SharpRake requested a review from a team as a code owner January 18, 2025 01:13
Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for ornate-narwhal-088216 ready!

Name Link
🔨 Latest commit 770733b
🔍 Latest deploy log https://app.netlify.com/sites/ornate-narwhal-088216/deploys/678b00470fdcbe0008c165aa
😎 Deploy Preview https://deploy-preview-2025--ornate-narwhal-088216.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SharpRake SharpRake marked this pull request as draft January 18, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant