Add annotations as labels to (Docker) ConfigFile #900
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Young <lyoung@confluent.io>
lyoung-confluent
force-pushed
the
patch-2
branch
from
d59c326 to
83dd3a4
Compare
|
Please sign your commits with sigstore: https://docs.sigstore.dev/signing/gitsign/ |
|
Hey 👋🏻 I'm also interested in this change. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building an image with
--annotationsthe annotations will be correctly added to theannotationsof the OCI Image Index, however they will not be added to theLabelsfield of the Docker config file, it is always an empty map currently. This PR attaches the annotations to the labels field as well so automated tools that extract labels from this (legacy) file will succeed.