-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: constraints api integration #3
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just two little nits I've noticed so far
Co-authored-by: Jonas Bostoen <mempirate@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Made a first review. Will do another round more detailed at a later time
crates/common/src/proofs.rs
Outdated
let mut found = false; | ||
for constraint in constraints { | ||
for (saved_hash, leaf) in &constraint.proof_data { | ||
if **saved_hash == ****hash { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand why it's needed but it looks crazy ahah can you move this to logic to a separate, documented function explaining why do we need this many rounds of deref
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved this by taking slice value
Co-authored-by: Lorenzo <thedevbirb@users.noreply.github.com> Co-authored-by: nicolas <merklefruit@users.noreply.github.com>
Co-authored-by: Lorenzo <thedevbirb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will need to see this tested before I can do a proper review, the changes are quite big here - and I don't know the codebase well yet
feat(builder-api): delegations getter fn
fix: return signed delegations
feat(api): constraints getter functions
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
No description provided.