Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degrade more gracefully on promise inpsection capabilities #51

Merged

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Jan 26, 2022

Loupe fails on Node since 16 which dropped process.binding('util').getPromiseDetail. See nodejs/node#40054 for more.

This more gracefully degrades when that function is not available.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #51 (c6e4c0f) into master (b985e4f) will decrease coverage by 1.82%.
The diff coverage is 84.61%.

❗ Current head c6e4c0f differs from pull request most recent head 25e06a1. Consider uploading reports for the commit 25e06a1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   74.55%   72.72%   -1.83%     
==========================================
  Files          19       19              
  Lines         621      627       +6     
==========================================
- Hits          463      456       -7     
- Misses        158      171      +13     
Impacted Files Coverage Δ
index.js 40.00% <83.33%> (-3.21%) ⬇️
lib/promise.js 45.00% <85.71%> (-2.37%) ⬇️
lib/typedarray.js 94.28% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b985e4f...25e06a1. Read the comment docs.

@keithamus keithamus force-pushed the degrade-more-gracefully-on-promise-inpsection-capabilities branch 2 times, most recently from 848c801 to 25e06a1 Compare January 26, 2022 12:10
@keithamus keithamus force-pushed the degrade-more-gracefully-on-promise-inpsection-capabilities branch from 25e06a1 to 421ae2e Compare January 26, 2022 12:13
Copy link
Member

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@keithamus keithamus merged commit 924cafe into master Jan 26, 2022
@keithamus keithamus deleted the degrade-more-gracefully-on-promise-inpsection-capabilities branch January 26, 2022 12:18
@github-actions
Copy link

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants