Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #1118

Merged
merged 1 commit into from
Jan 14, 2018
Merged

chore: update dependencies #1118

merged 1 commit into from
Jan 14, 2018

Conversation

meeber
Copy link
Contributor

@meeber meeber commented Jan 7, 2018

@meeber meeber requested a review from a team as a code owner January 7, 2018 16:03
@codecov
Copy link

codecov bot commented Jan 7, 2018

Codecov Report

Merging #1118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          32       32           
  Lines        1628     1628           
  Branches      393      393           
=======================================
  Hits         1524     1524           
  Misses        104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54f71c...6a1840b. Read the comment docs.

@sukrosono
Copy link
Contributor

Yay, ah karma 2.0.0 .

@meeber
Copy link
Contributor Author

meeber commented Jan 14, 2018

@keithamus Given that everyone seems extra busy lately, do you want to start merging minor PRs like this after 1 approval instead of 2?

Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meeber maybe I can help with minor PRs. Anything else you're thinking of?

This one looks good, merging!

@astorije astorije merged commit c94f4b6 into chaijs:master Jan 14, 2018
@meeber
Copy link
Contributor Author

meeber commented Jan 14, 2018

@astorije Thank you sir! Another one I'm thinking of is #1085.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants