-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor warnings under firefox / jslint? #775
Comments
|
Hi @gregglind, thanks for the issue and the PR! I've seen where you work at your GitHub Profile and I'd like to inform you that you currently achieved one of my life goals, which is to work for Mozilla 😄 Well, regarding the issue, we already thought about that and we also talked about it here. But, summarizing, we do plan to add it to our code, but we are planning to move everything we can to separate repositories and to that there (as @keithamus said on the comment I linked). However I feel like we could already start using it, maybe even before @meeber @keithamus What do you think about it? Maybe we could reuse the Thanks again for getting in touch, keep up with the good work you guys have been doing at Mozilla, you are my heroes. |
@lucasfcosta, we are always hiring and Brasileiros are welcome! gregglind@m.....com if you want to get in touch! |
I'd very much like to get eslint working, but IMO I feel like we're better off focussing on splitting out the modules, as each one can be written with a standard code style in mind - than by trying to refactor this codebase to only eventually split it out later. |
when using chai, firefox has several minor complaints
These would have been cause by using
eslint
withno-redeclare
: http://eslint.org/docs/rules/no-redeclareSolution
eslint
step in the build / deploy process.Thanks!
GL
The text was updated successfully, but these errors were encountered: