Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spandrel to 0.4.0, spandrel_extra_arches to 0.2.0 #3038

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

the-database
Copy link
Contributor

I tested PyTorch upscaling with MoSR and ESRGAN and didn't see any issues. Let me know if there's anything else I should test.

@umzi2
Copy link

umzi2 commented Oct 12, 2024

@the-database
Copy link
Contributor Author

https://github.com/chaiNNer-org/chaiNNer/blob/main/backend/src/packages/chaiNNer_pytorch/pytorch/io/load_model.py#L18 chaiNNer-org/spandrel@c3aa562#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R63 As far as I remember, this change in the extra_arches connection interface breaks the load_model node for some people

Do you know under what conditions load_model is broken for some people? I'm not able to reproduce on Windows, I've tested loading models for architectures from both spandrel and spandrel_extra_arches. Maybe the issue happened when only spandrel was updated without updating spandrel_extra_arches?

@joeyballentine Let me know if there's anything else you want me to check before this can get merged.

@joeyballentine
Copy link
Member

I think it was just from people updating spandrel without updating extra arches.

I should have some time tonight to review and get this merged. Sorry for the delay

@joeyballentine joeyballentine merged commit 95fe80d into chaiNNer-org:main Oct 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants