Add a "simple" mode for saving video #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
May 19, 2024
backend/src/packages/chaiNNer_standard/image/video_frames/save_video.py
Outdated
Show resolved
Hide resolved
Not sure. If it's easy to add, then why not. I just think that it should have "lossless" in the name of the option if you add it.
I think both are used, so maybe both? |
|
I decided not to add AVI for now. We can add that if anyone wants it. I also added a AVC and HEVC to the h264 and h265 labels, respectively. Also, I made it hide the quality slider for GIF (like advanced mode does) |
backend/src/packages/chaiNNer_standard/image/video_frames/save_video.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/image/video_frames/save_video.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/image/video_frames/save_video.py
Outdated
Show resolved
Hide resolved
|
I think we need a label for the additional params text box. Otherwise gtg |
RunDevelopment
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People often have confusion as to why the quality (crf) slider is what it is, or what the preset option does. If you don't know FFMPEG, then those things make no sense. Those users probably also don't know anything about encoders or formats.
So, I made a "simple" mode. It gives only a few options for formats, and uses a quality slider from 0-100 that sets both the CRF and preset values. This should make the node much more easily usable and intuitive for non-superusers
Open questions: