Manually set python encoding env var in subprocesses (to fix language issue) #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I figured out a way to simulate it (just have the subprocess output "Я"), and this does not fix it. the good thing is, i should be able to figure out a solution now. |
|
Seems that this does fix the issue: https://discord.com/channels/930865462852591648/1045361136196919366/1232400378608357470 The way I was testing this must have not been representative of the actual problem. So, this should be good to go and should fix the issue. |
RunDevelopment
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allegedly (according to this), this is how you force a python subprocess to output utf-8 only.
This should theoretically fix the remaining issues around people using non-utf8 windows languages. I have not tested this myself as my system language is english.