Skip to content

Commit

Permalink
newrelic#2154, replace "start up" to "start-up"
Browse files Browse the repository at this point in the history
  • Loading branch information
chahmedejaz committed Oct 10, 2023
1 parent 4c4cfd0 commit 49cbf98
Show file tree
Hide file tree
Showing 11 changed files with 77 additions and 77 deletions.
2 changes: 1 addition & 1 deletion .github/actions/annotate/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ A pre-commit hook is provided that can help keep dist/index.js in tune with loca
# Using Node as a REPL

If you're developing or working on the index.js script, it can be handy to try out stuff
locally. To do that, use Node to start up a REPL shell by running it from the action's folder:
locally. To do that, use Node to start-up a REPL shell by running it from the action's folder:

```
cd .github/workflow/actions/annotate
Expand Down
14 changes: 7 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Version <dev> brings support for gleaning a Docker container id from cgroups v2

- **Feature: Prevent the agent from starting in rails commands in Rails 7**

Previously, the agent ignored many Rails commands by default, such as `rails routes`, using Rake-specific logic. This was accomplished by setting these commands as default values for the config option `autostart.denylisted_rake_tasks`. However, Rails 7 no longer uses Rake for these commands, causing the agent to start running and attempting to record data when running these commands. The commands have now been added to the default value for the config option `autostart.denylisted_constants`, which will allow the agent to recognize these commands correctly in Rails 7 and prevent the agent from starting during ignored tasks. Note that the agent will continue to start up when the `rails server` and `rails runner` commands are invoked. [PR#2239](https://github.com/newrelic/newrelic-ruby-agent/pull/2239)
Previously, the agent ignored many Rails commands by default, such as `rails routes`, using Rake-specific logic. This was accomplished by setting these commands as default values for the config option `autostart.denylisted_rake_tasks`. However, Rails 7 no longer uses Rake for these commands, causing the agent to start running and attempting to record data when running these commands. The commands have now been added to the default value for the config option `autostart.denylisted_constants`, which will allow the agent to recognize these commands correctly in Rails 7 and prevent the agent from starting during ignored tasks. Note that the agent will continue to start-up when the `rails server` and `rails runner` commands are invoked. [PR#2239](https://github.com/newrelic/newrelic-ruby-agent/pull/2239)

- **Feature: Enhance Docker container id reporting**

Expand Down Expand Up @@ -456,7 +456,7 @@ Version 8.15.0 of the agent confirms compatibility with Ruby 3.2.0, adds instrum

| Configuration name | Default | Behavior |
| --------------------------------- | ------- | ------------------------------------------------------------------------------------------------------------------------------- |
| `instrumentation.concurrent_ruby` | auto | Controls auto-instrumentation of the concurrent-ruby library at start up. May be one of `auto`, `prepend`, `chain`, `disabled`. |
| `instrumentation.concurrent_ruby` | auto | Controls auto-instrumentation of the concurrent-ruby library at start-up. May be one of `auto`, `prepend`, `chain`, `disabled`. |

- **Infinite Tracing: Use batching and compression**

Expand Down Expand Up @@ -555,7 +555,7 @@ Version 8.12.0 of the agent delivers new Elasticsearch instrumentation, increase

| Configuration name | Default | Behavior |
| --------------------------------- | ------- | ----------------------------------------------------------------------------------------------------------------------------- |
| `instrumentation.elasticsearch` | auto | Controls auto-instrumentation of the elasticsearch library at start up. May be one of `auto`, `prepend`, `chain`, `disabled`. |
| `instrumentation.elasticsearch` | auto | Controls auto-instrumentation of the elasticsearch library at start-up. May be one of `auto`, `prepend`, `chain`, `disabled`. |
| `elasticsearch.capture_queries` | true | If `true`, the agent captures Elasticsearch queries in transaction traces. |
| `elasticsearch.obfuscate_queries` | true | If `true`, the agent obfuscates Elasticsearch queries in transaction traces. |

Expand Down Expand Up @@ -1170,7 +1170,7 @@ The multiverse collection of test suites requires a variety of data handling sof
- **Bugfix: Prevent browser monitoring middleware from installing to middleware multiple times**

In rare cases on jRuby, the BrowserMonitoring middleware could attempt to install itself
multiple times at start up. This bug fix addresses that by using a mutex to introduce
multiple times at start-up. This bug fix addresses that by using a mutex to introduce
thread safety to the operation. Sintra in particular can have this race condition because
its middleware stack is not installed until the first request is received.

Expand All @@ -1181,7 +1181,7 @@ The multiverse collection of test suites requires a variety of data handling sof
- **Bugfix: nil Middlewares injection now prevented and gracefully handled in Sinatra**

Previously, the agent could potentially inject multiples of an instrumented middleware if Sinatra received many
requests at once during start up and initialization due to Sinatra's ability to delay full start up as long as possible.
requests at once during start-up and initialization due to Sinatra's ability to delay full start-up as long as possible.
This has now been fixed and the Ruby agent correctly instruments only once as well as gracefully handles nil middleware
classes in general.

Expand Down Expand Up @@ -3398,7 +3398,7 @@ For more details on our Resque support, see https://docs.newrelic.com/docs/agent
- Support agent when starting Resque Pool from Rake task

When running resque-pool with its provided rake tasks, the agent would not
start up properly. Thanks Tiago Sousa for the fix!
start-up properly. Thanks Tiago Sousa for the fix!

- Fix for DelayedJob + Rails 4.x queue depth metrics

Expand Down Expand Up @@ -5342,7 +5342,7 @@ Agent improvements to support future RPM enhancements
- fix incompatibility in the developer mode with the safe_erb plugin
- fix module namespace issue causing an error accessing
NewRelic::Instrumentation modules
- fix issue where the agent sometimes failed to start up if there was a
- fix issue where the agent sometimes failed to start-up if there was a
transient network problem
- fix IgnoreSilentlyException message

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module NewRelic::Agent
Agent.class_eval do
def new_infinite_tracer
# We must start streaming in a thread or we block/deadlock the
# entire start up process for the Agent.
# entire start-up process for the Agent.
InfiniteTracing::Client.new.tap do |client|
@infinite_tracer_thread = InfiniteTracing::Worker.new(:infinite_tracer) do
NewRelic::Agent.logger.debug('Opening Infinite Tracer Stream with gRPC server')
Expand Down
Loading

0 comments on commit 49cbf98

Please sign in to comment.