Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various optimizations #1724

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Various optimizations #1724

merged 2 commits into from
Mar 14, 2025

Conversation

frankrousseau
Copy link
Contributor

Problem

  • The shot page loads data twice while it's a big request
  • Posting a new comment generates many requests related to real time, which can flood the server

Solution

  • Do not load data when production or episode is changed if data are already loading
  • Reload comment only if the task is listed in the todo list or if the task panel is open

@frankrousseau
[shots] Remove duplicate loading
1ebe99f
@frankrousseau
[realtime] Reload comment only when needed
dbf54b6 
The event system add the task status information. So if there is no
other information needed, it is uncessary to reload the comment.
@NicoPennec NicoPennec merged commit e4e5649 into cgwire:main Mar 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoPennec NicoPennec NicoPennec approved these changes

Assignees

@frankrousseau frankrousseau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankrousseau @NicoPennec