Skip to content

Commit

Permalink
chore(TS): IText behavior mixins (fabricjs#8421)
Browse files Browse the repository at this point in the history
  • Loading branch information
ShaMan123 authored and frankrousseau committed Jan 6, 2023
1 parent f748d9d commit 66fbd7c
Show file tree
Hide file tree
Showing 13 changed files with 2,421 additions and 2,471 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
size: { fabric: { minified: fs.statSync('dist/fabric.min.js').size, bundled: fs.statSync('dist/fabric.js').size } }
});
- name: checkout src files
run: git checkout origin/master -- src
run: git checkout origin/master -- src index.js HEADER.js
- name: upstream build stats
run: npm run build -- -s
- name: persist
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [next]

- chore(TS): migrate text classes/mixins [#8408](https://github.com/fabricjs/fabric.js/pull/8408)
- chore(TS): migrate Collection [#8433](https://github.com/fabricjs/fabric.js/pull/8433)
- ci(): Simplify filestats even more [#8449](https://github.com/fabricjs/fabric.js/pull/8449)
- chore(TS): migrate filter backends [#8403](https://github.com/fabricjs/fabric.js/pull/8403)
Expand Down
3 changes: 0 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ import './src/filters/composed_filter.class'; // optional image_filters
import './src/filters/hue_rotation.class'; // optional image_filters
import './src/shapes/text.class'; // optional text
import './src/shapes/itext.class'; // optional itext
import './src/mixins/itext_behavior.mixin'; // optional itext
import './src/mixins/itext_click_behavior.mixin'; // optional itext
import './src/mixins/itext_key_behavior.mixin'; // optional itext
import './src/mixins/itext.svg_export'; // optional itext
import './src/shapes/textbox.class'; // optional textbox
import './src/controls'; // optional interaction
Expand Down
4 changes: 2 additions & 2 deletions src/mixins/canvas_events.mixin.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
//@ts-nocheck

import { stopEvent } from '../util/dom_event';
import { fireEvent } from '../util/fireEvent';

(function (global) {
Expand Down Expand Up @@ -266,8 +267,7 @@ import { fireEvent } from '../util/fireEvent';
addListener(this.upperCanvasEl, 'drag', this._onDragProgress);
return;
}
e.preventDefault();
e.stopPropagation();
stopEvent(e);
},

/**
Expand Down
Loading

0 comments on commit 66fbd7c

Please sign in to comment.