Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding boxes #69

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Bounding boxes #69

merged 4 commits into from
Jun 27, 2024

Conversation

Courtsilius
Copy link
Collaborator

Added rooms, slopes and objects that can be used to define rooms as well as some examples (that will be removed in the future, of course, but can stay rn imo as a demo)

Right now they are rendered as follows:

  • Rooms = green wireframes
  • Slopes = white wireframes
  • Objects = red wireframes

Rendering is still handled in the FirstPersonController right now, will be moved though together with #8 .

Collision detection is handled in the FirstPersonController as well, but that can stay there.

@Courtsilius Courtsilius requested a review from LouisHain June 21, 2024 10:19
@Courtsilius Courtsilius linked an issue Jun 25, 2024 that may be closed by this pull request
Copy link
Collaborator

@LouisHain LouisHain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a boolean constant for displaying wireframes so you only have to change the constant instead of changing the MeshBasicMaterial wireframe boolean for every single wireframe rendered object.
Change the movement when walking against objects to be the same sliding movement that you get when walking against walls. Should add way smoover movement in rooms with many objects.
Slopes need to be rotatable to account for stairs not always facing one direction. We can ignore that issue for now though, as we probably wont have stairs scanned at KIMS.
Elsewise the code is fine and easily expandable to account for more objects rendered! Good job!

@Courtsilius
Copy link
Collaborator Author

Thanks for the review. As for the rendering being done optionally, that needs to be tackled when both features that are currently worked on are ready and can be moved to a seperate rendering class.

The QoL change of not getting stuck on objects as easily also needs to be addressed in the next sprint, as it's too small of a timeframe between that and the start of the next sprint, so we'll open a new ticket for that.

@Courtsilius Courtsilius merged commit ba037f7 into main Jun 27, 2024
@Courtsilius Courtsilius deleted the feature/9-bounding-boxes branch June 27, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounding Boxes
2 participants