Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: _globals schema nesting (fixes #75) #76

Merged
merged 2 commits into from
May 30, 2023
Merged

Fix: _globals schema nesting (fixes #75) #76

merged 2 commits into from
May 30, 2023

Conversation

joe-allen-89
Copy link
Contributor

Fixes (#75)

Fix

@joe-allen-89 joe-allen-89 self-assigned this Mar 22, 2023
@joe-allen-89 joe-allen-89 linked an issue Mar 22, 2023 that may be closed by this pull request
Fix nesting on v1 schema _globals #75
Closed
@kirsty-hames
Copy link
Contributor

kirsty-hames commented Mar 28, 2023 •
edited
Loading

One thing I have just spotted @joe-allen-89 is there isn't a reference to _globals._accessibility._ariaLabels.visua11y in the schemas. Should plugin _globals be added via the plugin schema?

This applies to both properties.schema as well as the new schemas.

@oliverfoster
Copy link
Member

bump @joe-allen-89

@chris-steele
Copy link

@kirsty-hames and @joe-allen-89 does this look ok?

@oliverfoster oliverfoster merged commit e7bd9ae into master May 30, 2023
@oliverfoster oliverfoster deleted the issue/75 branch May 30, 2023 09:11
github-actions bot pushed a commit that referenced this pull request May 30, 2023
@semantic-release-bot
Chore(release): 2.2.4 [skip ci]
1e73652 
## [2.2.4](v2.2.3...v2.2.4) (2023-05-30)

### Fix

* _globals schema nesting (fixes #75) (#76) ([e7bd9ae](e7bd9ae)), closes [#75](#75) [#76](#76)
@github-actions
Copy link

🎉 This PR is included in version 2.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix nesting on v1 schema _globals
4 participants
@joe-allen-89 @kirsty-hames @oliverfoster @chris-steele