Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Updated RTL styling (fixes #105) #106

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Update: Updated RTL styling (fixes #105) #106

merged 3 commits into from
Dec 18, 2023

Conversation

guywillis
Copy link
Contributor

Fixes #105

Update

  • Updated RTL styling to remove unnecessary declarations

@guywillis guywillis self-assigned this Dec 15, 2023
@kirsty-hames
Copy link
Contributor

kirsty-hames commented Dec 15, 2023

Hey @guywillis, could you update line 279 to margin-inline-start: @btn-padding; to fix the margin display for RTL please?

close-btn-margin

This issue existed before the PR but makes sense to add it here whilst you're updating the RTL styles.

@kirsty-hames
Copy link
Contributor

Thanks @guywillis. Just one more amend for line 169. Could this be padding-inline-end: @item-padding / 2; please?

readability-item

Otherwise this is working as expected thanks.

@kirsty-hames kirsty-hames merged commit 1e660f1 into master Dec 18, 2023
@kirsty-hames kirsty-hames deleted the issue/105 branch December 18, 2023 09:24
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
# [2.8.0](v2.7.0...v2.8.0) (2023-12-18)

### Update

* Updated RTL styling (fixes #105) (#106) ([1e660f1](1e660f1)), closes [#105](#105) [#106](#106)
Copy link

🎉 This PR is included in version 2.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise RTL styling
2 participants