-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Introduce DioExceptionReadableStringBuilder
#2297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2024
I guess we can go for the builder, any thought about this? @ueman @kuhnroyal |
I think this is good, same goes for the log level. |
AlexV525
force-pushed
the
feat/dio-exception-log-builder
branch
from
December 16, 2024 12:49
a8a8d38
to
ee79933
Compare
Signed-off-by: Alex Li <github@alexv525.com>
AlexV525
changed the title
✨ Introduce
✨ Introduce Jan 28, 2025
DioExceptionLogBuilder
DioExceptionReadableStringBuilder
Signed-off-by: Alex Li <github@alexv525.com>
Signed-off-by: Alex Li <github@alexv525.com>
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1949
Resolves #2287
Developers may want the URL of the exception to know what endpoint has gone wrong, or they want to have fewer tips about what the status code means. If we open too many flags to support various logging content, it will be a mess eventually.
Introducing the
DioExceptionReadableStringBuilder
easily builds text content from theDioException
.New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding package