Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two more Poplar1 test vectors #459

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

divergentdave
Copy link
Collaborator

This adds two additional Poplar1 test vectors, with BITS=11. One evaluates the first level, and the other evaluates the last level. This addition will flush out possible issues with byte order in the IDPF public share's control bit correction words. (the existing test vectors are all for BITS=4)

@cjpatton cjpatton self-requested a review October 8, 2024 21:33
Copy link
Collaborator

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially addresses #312 (includes more test vectors).

@divergentdave divergentdave merged commit d6209e8 into main Oct 8, 2024
6 checks passed
@divergentdave divergentdave deleted the david/additional-poplar1-test-vectors branch October 8, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants