Resolve open issues for #255 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@divergentdave let me know if you'd like me to change the public share type for |
cjpatton
force-pushed
the
cjpatton/255-finish-it
branch
from
7ba120c to
e4cf35c
Compare
|
Rebased and squashed. |
cjpatton
force-pushed
the
cjpatton/255-finish-it
branch
from
e4cf35c to
6751d9e
Compare
cjpatton
commented
Aug 7, 2024
cjpatton
force-pushed
the
cjpatton/255-finish-it
branch
3 times, most recently
from
1795e3a to
d194e29
Compare
|
Addressed all of the lints. To compare to what you last reviewed: |
cjpatton
force-pushed
the
cjpatton/255-finish-it
branch
from
d194e29 to
7171378
Compare
|
Rebased. |
cjpatton
commented
Aug 16, 2024
divergentdave
approved these changes
Aug 19, 2024
Two questions remain.
First, for consistency with other sections, allow the IDPF to define its
own type for the public share and express the encoding correction words
for {{BBCGG21}} in TLS-syntax.
Second, for consistency with other sections, we express the encoding of
`Poplar1`'s aggregation parameter in TLS-syntax. This is slightly hairy
because of the prefix packing procedure, but this can be factored out
pretty nicely.
cjpatton
force-pushed
the
cjpatton/255-finish-it
branch
from
90b7357 to
109ec2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #255.
Two questions remain.
First, for consistency with other sections, allow the IDPF to define its own type for the public share and express the encoding correction words for {{BBCGG21}} in TLS-syntax.
Second, for consistency with other sections, we express the encoding of
Poplar1's aggregation parameter in TLS-syntax. This is slightly hairy because of the prefix packing procedure, but this can be factored out pretty nicely.