Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization details and update some references #43

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Add serialization details and update some references #43

merged 2 commits into from
Apr 1, 2024

Conversation

chris-wood
Copy link
Collaborator

cc @cathieyun for 👀

@cathieyun
Copy link

Thanks for adding more details on the serialization format, that should help avoid serialization inconsistencies going forward. LGTM

@jedisct1
Copy link
Collaborator

jedisct1 commented Apr 1, 2024

LGTM! These clarifications are useful.

@chris-wood chris-wood merged commit c0ed609 into main Apr 1, 2024
2 checks passed
@chris-wood chris-wood mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedisct1 jedisct1 Awaiting requested review from jedisct1 jedisct1 is a code owner

@tedeaton tedeaton Awaiting requested review from tedeaton tedeaton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-wood @cathieyun @jedisct1