Simplify the testing matrix and add isort #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbarton
requested review from
rosskarchner,
richaagarwal,
higs4281,
chosak and
hillaryj
chosak
approved these changes
Jan 2, 2018
|
|
||
| To use Wagtail-Flags you first need to define the flag, use the flag in code, and define conditions for the flag to be enabled. | ||
| To use Wagtail-Flags you first need to define the flag, use the flag, and define conditions for the flag to be enabled. | ||
|
|
||
| First, define the flag in Django `settings.py`: | ||
|
|
There was a problem hiding this comment.
This wasn't changed in this PR, but as part of reviewing this I noticed a missing ) at the end of line 94. Instead of
url(r'^/mypage$', TemplateView.as_view(template_name='mytemplate.html'),it should be
url(r'^/mypage$', TemplateView.as_view(template_name='mytemplate.html')),
README.md
Outdated
| from flags.state import flag_enabled | ||
|
|
||
| if flag_enabled('MY_FLAG', request=a_request): | ||
| print("My feature flag is enabled") |
There was a problem hiding this comment.
Is this intentionally indented 8 spaces instead of 4?
README.md
Outdated
| Django templates: | ||
|
|
||
| ```django | ||
| {% flag_enabled 'MY_FLAG' as my_flag %} |
There was a problem hiding this comment.
It might be nice to include the
{% load feature_flags %}line here (as above in Quickstart) as this is necessary for this tag to work.
higs4281
approved these changes
Jan 3, 2018
willbarton
force-pushed
the
testing-sorting
branch
from
b1bd0e4 to
af8c07e
Compare
willbarton
force-pushed
the
testing-sorting
branch
from
af8c07e to
ee2419b
Compare
|
@higs4281 fixed that too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: