Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav Menu Presentation #1086

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Nav Menu Presentation #1086

merged 8 commits into from
Dec 16, 2024

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Dec 11, 2024 •
edited
Loading

Adding additional logic to configure what navbar options are available and under what circumstances they appear

Changes

  • Updated the navbar links logic so that it shows the correct links on the correct pages
  • Added e2e test logic to validate that the navbar is configured correctly in a few different places

How to test this PR

  1. Verify that the pipeline is passing
  2. Pull the branch
  3. Launch/releaunch the stack as necessary
  4. Access the non authenticated landing page
  5. Verify that there are no navbar options
  6. Login as an non-associated user
  7. Verify that only the the logout nav option appears
  8. Login as a full associated user
  9. Navigate to the home page
  10. Verify that the full nav options appear

This was linked to issues Dec 11, 2024
[Story] Full navigation menu except in specific cases cfpb/sbl-project#294
Closed
[Story] Log out option when user profile is completed cfpb/sbl-project#293
Closed
@tanner-ricks tanner-ricks changed the title Draft: Nav Menu Presentation Nav Menu Presentation Dec 11, 2024
@tanner-ricks tanner-ricks marked this pull request as ready for review December 11, 2024 18:53
@tanner-ricks tanner-ricks marked this pull request as draft December 12, 2024 22:08
@tanner-ricks tanner-ricks marked this pull request as ready for review December 12, 2024 22:50
billhimmelsbach
billhimmelsbach requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small change:

src/utils/useHeaderAuthLinks.tsx Outdated Show resolved Hide resolved
@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented Dec 16, 2024 •
edited
Loading

Got some testing errors, but I don't think they're related to your changes since previously passing PRs are now failing, but maybe a change on the backend.

@billhimmelsbach
Copy link
Contributor

Ok, they fixed the missing env vars so everything is fine again.

billhimmelsbach
billhimmelsbach approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the update.

@tanner-ricks tanner-ricks merged commit 9c51143 into main Dec 16, 2024
10 checks passed
@tanner-ricks tanner-ricks deleted the 293-nav-menu-presentation branch December 16, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

@meissadia meissadia Awaiting requested review from meissadia meissadia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Story] Full navigation menu except in specific cases [Story] Log out option when user profile is completed
2 participants
@tanner-ricks @billhimmelsbach