Remove validation_results from get_submissions endpoint

src/sbl_filing_api/entities/models/dto.py

@@ -14,21 +14,26 @@ class UserActionDTO(BaseModel):
     action_type: UserActionType
 
 
-class SubmissionDTO(BaseModel):
+class SubmissionBaseDTO(BaseModel):
     model_config = ConfigDict(from_attributes=True)
 
     id: int | None = None
     counter: int
     state: SubmissionState | None = None
     validation_ruleset_version: str | None = None
-    validation_results: Dict[str, Any] | None = None
     submission_time: datetime | None = None
     filename: str
     total_records: int | None = None
     submitter: UserActionDTO
     accepter: UserActionDTO | None = None
 
 
+class SubmissionDTO(SubmissionBaseDTO):
+    model_config = ConfigDict(from_attributes=True)
+
+    validation_results: Dict[str, Any] | None = None
+
+
 class FilingTaskDTO(BaseModel):
     model_config = ConfigDict(from_attributes=True)
 

src/sbl_filing_api/entities/repos/submission_repo.py

@@ -1,6 +1,7 @@
 import logging
 
 from sqlalchemy import select, desc
+from sqlalchemy.orm import defer, QueryableAttribute
 from sqlalchemy.ext.asyncio import AsyncSession
 from typing import Any, List, TypeVar
 from sbl_filing_api.entities.engine.engine import SessionLocal
@@ -36,7 +37,7 @@ async def get_submissions(session: AsyncSession, lei: str = None, filing_period:
     if lei and filing_period:
         filing = await get_filing(session, lei=lei, filing_period=filing_period)
         filing_id = filing.id
-    return await query_helper(session, SubmissionDAO, filing=filing_id)
+    return await query_helper(session, SubmissionDAO, defers=[SubmissionDAO.validation_results], filing=filing_id)
 
 
 async def get_latest_submission(session: AsyncSession, lei: str, filing_period: str) -> SubmissionDAO | None:
@@ -190,8 +191,12 @@ async def upsert_helper(session: AsyncSession, original_data: Any, table_obj: T)
     return new_dao
 
 
-async def query_helper(session: AsyncSession, table_obj: T, **filter_args) -> List[T]:
+async def query_helper(
+    session: AsyncSession, table_obj: T, *, defers: List[QueryableAttribute] | None = None, **filter_args
+) -> List[T]:
     stmt = select(table_obj)
+    if defers:
+        stmt = stmt.options(defer(*defers))
     # remove empty args
     filter_args = {k: v for k, v in filter_args.items() if v is not None}
     if filter_args:

src/sbl_filing_api/routers/filing.py

@@ -29,6 +29,7 @@
     SubmissionState,
     UserActionDTO,
     VoluntaryUpdateDTO,
+    SubmissionBaseDTO,
 )
 
 from sbl_filing_api.entities.repos import submission_repo as repo
@@ -218,7 +219,7 @@ async def upload_file(request: Request, lei: str, period_code: str, file: Upload
         ) from e
 
 
-@router.get("/institutions/{lei}/filings/{period_code}/submissions", response_model=List[SubmissionDTO])
+@router.get("/institutions/{lei}/filings/{period_code}/submissions", response_model=List[SubmissionBaseDTO])
 @requires("authenticated")
 async def get_submissions(request: Request, lei: str, period_code: str):
     return await repo.get_submissions(request.state.db_session, lei, period_code)