Feature/8 add helm chart #9
Conversation
lchen-2101
requested review from
hkeeler,
guffee23,
aharjati,
nargis-sultani and
gduncklee
k8s/Chart.yaml
Outdated
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.0 | ||
|
|
||
| # This is the version number of the application being deployed. This version number should be | ||
| # incremented each time you make changes to the application. Versions are not expected to | ||
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "0.1.0" |
There was a problem hiding this comment.
How do these values get updated? Via CI process that increments them?
There was a problem hiding this comment.
@gduncklee what are your insights on this one?
There was a problem hiding this comment.
We can probably drop appVersion, which is optional and is typically duplicated by .Values.image.tag.
We could update the Chart's version value within CI, we would want to ensure it is handling semver. This is something that should be addressed in the future, in my opinion.
There was a problem hiding this comment.
dropped appVersion for now
k8s/templates/NOTES.txt
Outdated
There was a problem hiding this comment.
Is this file all boilerplate, or have you added anything specific to our project?
There was a problem hiding this comment.
This is boilerplate auto generated during the helm create process
k8s/templates/_helpers.tpl
Outdated
There was a problem hiding this comment.
Same question. Is this file all boilerplate, or have you added anything specific to our project?
There was a problem hiding this comment.
This one is also auto generated; it does define some variables that are used in the yaml files.
There was a problem hiding this comment.
Is it general practice to leave much of this file's setting with blank/empty values? To me, it seems more useful to populate this file with just the settings that are actually used, or will work as defaults, but will be overridden in higher environments.
There was a problem hiding this comment.
The blank values here are placeholders referenced as default values in other yaml files; if the blank values aren't here, and an overriding values file isn't provided, the chart would fail to "compile".
There was a problem hiding this comment.
The idea with leaving many values blank is to ensure a helm chart may deploy in nearly all use cases (k3s, minikube, etc).
Cloning this repository and running helm template . from the k8s dir renders the chart templates as defined in the values.yaml; however, this does none of the server-side testing.
I personally prefer leaving as many values in the values.yaml as blank unless the default set would apply to all possible environments we are deploying into.
closes #8