Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with empty state field in DTO #237

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Conversation

jcadam14
Copy link
Contributor

@jcadam14 jcadam14 commented Oct 1, 2024

Closes #236

Fixed an issue with empty state codes failing on sending an associated DTO back.

@jcadam14 jcadam14 self-assigned this Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/regtech_user_fi_management/entities/models
  dto.py
Project Total  

This report was generated by python-coverage-comment-action

hkeeler
hkeeler previously approved these changes Oct 1, 2024
@hkeeler
Copy link
Member

hkeeler commented Oct 1, 2024

Looks good, though black seems to be grumpy with some part of this change.

On a side note, I would expect that to prevent me from merging this, but it's not. Seems like all the branch protection rules are correct too. 🤔

@jcadam14
Copy link
Contributor Author

jcadam14 commented Oct 1, 2024

Looks good, though black seems to be grumpy with some part of this change.

On a side note, I would expect that to prevent me from merging this, but it's not. Seems like all the branch protection rules are correct too. 🤔

Yeah I was trying to fix black but was having git issues, all resolved

@jcadam14 jcadam14 requested a review from hkeeler October 1, 2024 21:47
@jcadam14 jcadam14 merged commit e0b1a08 into main Oct 1, 2024
7 checks passed
@jcadam14
Copy link
Contributor Author

jcadam14 commented Oct 1, 2024

Looks good, though black seems to be grumpy with some part of this change.

On a side note, I would expect that to prevent me from merging this, but it's not. Seems like all the branch protection rules are correct too. 🤔

Also yeah I've noticed that you can approve, and merge, even if a security or linting test fails. Actually good with the security thing because Snyk is continually failing for no reason on one of our repos (api-commons I believe) and it would keep us from ever merging anything since we have no control of that thing.

@hkeeler hkeeler deleted the fix_missing_state_code branch October 1, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow NONE for FinancialInstitutionWithRelationsDto
2 participants