-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue with empty state field in DTO #237
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
Looks good, though On a side note, I would expect that to prevent me from merging this, but it's not. Seems like all the branch protection rules are correct too. 🤔 |
Yeah I was trying to fix black but was having git issues, all resolved |
Also yeah I've noticed that you can approve, and merge, even if a security or linting test fails. Actually good with the security thing because Snyk is continually failing for no reason on one of our repos (api-commons I believe) and it would keep us from ever merging anything since we have no control of that thing. |
Closes #236
Fixed an issue with empty state codes failing on sending an associated DTO back.