Added Dockerfile apk add command #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Dockerfile apk add command that adds several dependencies
lchen-2101
reviewed
Aug 29, 2023
Dockerfile
Outdated
Comment on lines
5
to
8
| RUN apk add --update --no-cache --virtual .tmp-build-deps \ | ||
| gcc libc-dev linux-headers postgresql-dev \ | ||
| && apk add libffi-dev | ||
|
|
There was a problem hiding this comment.
figured out this is only an issue for the Apple chips, not relevant for other platforms; create a different Dockerfile specific for Apple chips.
Changes: - [chore] Reverted the Dockerfile to the original version - [feat] Created a 'Dockerfile.mac_chip' for Mac users with an Apple chip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Added
Dockerfile.mac_chipwith apk add command that adds several dependenciesNOTICE: This is for users with a Mac using an Apple chip.