Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify upsert function with a session.get() #90

Closed
jcadam14 opened this issue Jan 11, 2024 · 0 comments · Fixed by #91
Closed

Simplify upsert function with a session.get() #90

jcadam14 opened this issue Jan 11, 2024 · 0 comments · Fixed by #91
Assignees
@jcadam14

Comments

@jcadam14
Copy link
Contributor

The flush() then refresh() calls in the upsert_institution can be simplified to a single session.get() call which will return the latest version of that object fully populated with relationships.
@jcadam14 jcadam14 self-assigned this Jan 11, 2024
@jcadam14 jcadam14 mentioned this issue Jan 11, 2024
Merged
@jcadam14 jcadam14 linked a pull request Jan 11, 2024 that will close this issue
Changed upsert_institution to return a session.get() #91
Merged
lchen-2101 pushed a commit that referenced this issue Jan 17, 2024
@jcadam14
Changed upsert_institution to return a session.get() (#91)
21c52a1 
Closes #90 

Updated upsert_institution function to remove the flush and refresh and
simplified to return a session.get(dao, lei) which will return the
latest fully populated FIDao
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed upsert_institution to return a session.get() cfpb/regtech-user-fi-management
1 participant
@jcadam14