Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grad Path cypress tests #8731

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix Grad Path cypress tests #8731

merged 1 commit into from
Jan 30, 2025

Conversation

mistergone
Copy link
Member

A data mismatch is causing a failure in the cypress tests for Grad Path between live data and older data (for instance, the test data). These tests should not be based on databases anyway, so this PR will change these tests to be based on fixtures (dummy data).

Changes

  • Add fixture for testing school
  • Update values to reflect fixture data
  • Reformat constants.json for readability

How to test this PR

  1. Try the Grad Path tests. They should work regardless of data.
  2. Also the disclosures tests should work - they use some of the same fixtures, and while I reformatted one fixture, I didn't change the data inside.

- Add fixture for testing school
- Update values to reflect fixture data
- Reformat constants.json for readability
Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@mistergone mistergone added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit fff210f Jan 30, 2025
11 checks passed
@mistergone mistergone deleted the gp-cy-fix branch January 30, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants