Drop counselors with invalid zips when geocoding #8718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpears
force-pushed
the
drop-invalid-zips
branch
from
15a1239 to
399b17f
Compare
chosak
approved these changes
Jan 16, 2025
cfgov/housing_counselor/geocoder.py
Outdated
| logger.warning(f"{zipcode} not in zipcodes") | ||
| return False | ||
|
|
||
| return True | ||
|
|
||
| def geocode_counselor(self, counselor): | ||
| counselor = dict(counselor) |
There was a problem hiding this comment.
Can this line be removed since you already ensure the counselor object is a dict in filter_zipcodes?
There was a problem hiding this comment.
I don't think so, since the filter just removes entries from the list of counselors but doesn't modify them. I could do this to the whole list ahead of time though
There was a problem hiding this comment.
Did the above in the following two commits
higs4281
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if when the housing_counselor mgmt command attempts to geocode data with an invalid zipcode, it throws a
KeyError. This bails out of the command and thus causes our daily update to fail.Since we don't control this data, I think it would be better to simply drop the counselor with the invalid zip (while logging that this is being done). This should allow us to be more resilient to erroneous data creeping into the HUD list of counselors.