Use Highcharts fork with temporary .flat prop fix for missing plotline label #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates cfpb-chart-builder to temporarily use a fork of Highcharts. The fork fixes a conflicting
.flat
JS property which caused missing plotline labels (the projected data label) on all the charts that have projected data.The bug is in Chrome 69 and Firefox 62, in older versions of Highcharts. See this issue with description of the bug: highcharts/highcharts#8477
Here is the bug fix, from Highcharts v6.1.2: highcharts/highcharts@83b5d31
We had to backport this bug fix to an older version of Highcharts so we can launch with cfpb-chart-builder on Highcharts v5.0.11. We will upgrade to v6 post-launch ASAP but we anticipate major CSS development to get the charts working in our supported browsers and styled to match our designs, hence this PR.
Read the "Notes" below for a detailed description of how the forked Highcharts package was created.
Additions
Removals
Changes
fix-missing-plotline-label
includes the backported bug fixTesting
./setup.sh
gulp watch
Screenshots
Notes
more detailed description TBA, for now here were the steps i took. i'll add more context on why:
npm install
gulp scripts --file highcharts.src.js,highmaps.src.js,highstock.src.js,modules/stock.src.js
highcharts/code
folder to github cfarm/highcharts-dist (overwriting existing files):Todos
Checklist