This repository has been archived by the owner on Jan 31, 2018. It is now read-only.
Updated to use cf-core and new docs template and adds dynamic animation duration based on content height #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
August 7, 2014 20:12
…x and overlfow hidden.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "cf-expandables", | |||
| "version": "0.3.5", | |||
| "version": "1.4.0", | |||
There was a problem hiding this comment.
The update adds a new feature.
There was a problem hiding this comment.
Does it break back-compat, though?
Given a version number MAJOR.MINOR.PATCH, increment the:
- MAJOR version when you make incompatible API changes,
- MINOR version when you add functionality in a backwards-compatible manner, and
- PATCH version when you make backwards-compatible bug fixes.
There was a problem hiding this comment.
So we should just go to 0.4.0 for now.
There was a problem hiding this comment.
Haaa sorry, didn't realize I changed the major part... Whoops!
|
Fixed! |
| }; | ||
|
|
||
| $.fn.expandable.calculateExpandDuration = function( height ) { | ||
| return height * 4; |
There was a problem hiding this comment.
Should we put a max on these? Expandables can potentially be quite tall. At 500px tall, we're waiting 2 full seconds.
| name: Recommended expandable pattern | ||
| family: cf-expandables | ||
| notes: | ||
| - "Expandables can be built by combing the basic barebones structure |
|
Alrighty! Need to revisit some of the classing at some point (see #30), but this is good for now. |
Scotchester
added a commit
that referenced
this pull request
Aug 11, 2014
Updated to use cf-core and new docs template and adds dynamic animation duration based on content height
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.