Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Bug Fixes (DATAP-1570 and DATAP-1575) #556

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

cdmh219
Copy link
Collaborator

@cdmh219 cdmh219 commented Oct 30, 2024

Various Bug Fixes

  • Hide buttons from print view
  • Align charts in print view with associated legend
  • Increase margins on all sides for warning and error notifications

Additions

Removals

Changes

Testing

  • Run search query here
  • Press CMD + P
  • Print screen should match screenshots
  • Run warning query
  • Warning notification should match screenshot

Screenshots

Screenshot 2024-10-30 at 3 07 01 PM

Screenshot 2024-10-30 at 3 07 14 PM

Screenshot 2024-10-30 at 3 14 33 PM

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@cdmh219 cdmh219 requested a review from flacoman91 October 30, 2024 19:29
@flacoman91 flacoman91 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 91861ec Oct 30, 2024
2 checks passed
@flacoman91 flacoman91 deleted the DATAP-1570-DATAP-1575-Various-UI-Bug-Fixes branch October 30, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants