Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ww datap 412 mobile tour #491

Merged
merged 13 commits into from
Mar 5, 2024
Merged

Ww datap 412 mobile tour #491

merged 13 commits into from
Mar 5, 2024

Conversation

wwhorton
Copy link
Contributor

Updates the Tour to be mobile-friendly

Changes

  • changes to style rules at various screen widths
  • minor refactor of toggle button
  • conditionally adds steps to tour for mobile filter
  • adds promise and setInterval to wait for date inputs to render
  • adds logic to move to next step when the filter is toggled

Testing

  • yarn test should pass
  • Click through the tour at widths under 750px and verify that it's working as expected

Screenshots

Screen.Recording.2024-02-26.at.3.44.28.PM.mov

Notes

  • The promise/setInterval piece is necessary because the tour wasn't picking up the date filters, I suspect due to rendering time.
  • In the onBeforeChange hook I change the display value for the Next button with setAttribute because the IntroJs API method wasn't working.

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@wwhorton wwhorton requested a review from flacoman91 February 26, 2024 21:52
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the tour at superwide, normal desktop, and mobile phone widths and the tour looks good!

@flacoman91 flacoman91 added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit a0c937e Mar 5, 2024
1 of 2 checks passed
@flacoman91 flacoman91 deleted the ww-DATAP-412-mobile-tour branch March 5, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants