Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some build and test dependencies | Update to latest design-system 0.37.x #490

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Feb 22, 2024

Design system changes in cfpb/design-system@v0.27.0...v0.37.2

Note that a-micro-copy has been removed from the design system, but this project sets its own styles on that class.

Changes

  • Update some build and test dependencies
  • Update to latest design-system

Testing

  • PR checks should pass.

@anselmbradford anselmbradford changed the title Update some build and test dependencies Update some build and test dependencies | Update to latest design-system 0.37.x Feb 22, 2024
"@cfpb/cfpb-buttons": "0.37.0",
"@cfpb/cfpb-core": "0.37.0",
"@cfpb/cfpb-design-system": "^0.37.2",
"@cfpb/cfpb-expandables": "^0.37.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it all looks the same, but is this issue still valid?

#463

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here. Hopefully I got everything 96b0103

Before:
Screenshot 2024-02-22 at 4 50 37 PM

After:
Screenshot 2024-02-22 at 4 50 47 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that was fast. Faster than me trying to figure it out!

@anselmbradford
Copy link
Member Author

Fixes #463

Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anselmbradford anselmbradford added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit 9ff4a26 Feb 22, 2024
2 checks passed
@anselmbradford anselmbradford deleted the ans_update_deps branch February 22, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants