Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface reactor type doesn't do range reactors fully #73

Open
rwest opened this issue Apr 3, 2019 · 2 comments
Open

Surface reactor type doesn't do range reactors fully #73

rwest opened this issue Apr 3, 2019 · 2 comments
Milestone
Merge to master h...

Comments

@rwest
Copy link
Collaborator

rwest commented Apr 3, 2019

The PR ReactionMechanismGenerator#1331 introduced Range Based Reactors. I don't think this feature works for surface reactors yet?
@rwest rwest added this to the Merge to master hackathon milestone Apr 3, 2019
@rwest
Copy link
Collaborator Author

rwest commented Apr 19, 2019

Perhaps it works for T and P ranges, but not yet initial gas mole fractions or surface coverages

raise NotImplementedError("Can't do ranges on species concentrations for surface reactors yet.")

@rwest rwest changed the title Surface reactor type doesn't do range reactors Surface reactor type doesn't do range reactors fully Apr 22, 2019
@rwest
Copy link
Collaborator Author

rwest commented Apr 26, 2019

Matt says temperature now functions (after the hackathon)

@mliu49 mliu49 mentioned this issue Apr 26, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Merge to master hackathon
Development

No branches or pull requests
1 participant
@rwest