Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining RMG-Cat issues identified at hackathon #1590

Closed
12 tasks
mliu49 opened this issue Apr 26, 2019 · 1 comment
Closed
12 tasks

Remaining RMG-Cat issues identified at hackathon #1590

mliu49 opened this issue Apr 26, 2019 · 1 comment
Labels
abandoned abandoned issue/PR as determined by actions bot stale stale issue/PR as determined by actions bot Topic: Catalysis

Comments

@mliu49
Copy link
Contributor

mliu49 commented Apr 26, 2019

I'm placing all of the unresolved issues which were identified during the hackathon here for now. Items can be moved to separate issues if the need arises.

  • Filter reactions for SurfaceReactor not implemented
  • Pressure not integrated for in SurfaceReactor
  • Jacobian/sensitivity analysis not implemented in SurfaceReactor
  • Unit tests needed for SurfaceRateCoefficient in rmgpy/quantity.py
  • Hard coding in family.py checks for 'adsorption' in family name
  • Update images for kinetics families
  • Creation of gas phase molecule from surface molecule in thermo.py could (should?) be made a molecule method, with appropriate unit tests

Topics with existing issues:

@github-actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Jun 21, 2023
@github-actions github-actions bot added the abandoned abandoned issue/PR as determined by actions bot label Jul 22, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned abandoned issue/PR as determined by actions bot stale stale issue/PR as determined by actions bot Topic: Catalysis
Projects
None yet
Development

No branches or pull requests

1 participant